adriangb commented on PR #25163: URL: https://github.com/apache/datafusion/pull/25163#issuecomment-5625321869
Heads-up on a merge-order interaction: https://github.com/apache/datafusion/pull/25175 (timezone characterization tests) currently pins the *current* behaviour of these fields as errors — ``` query error DataFusion error: Execution error: Date part 'timezone_hour' not supported SELECT date_part('timezone_hour', ts) FROM day_denver ``` — in `datafusion/sqllogictest/test_files/datetime/timestamps_timezone.slt`, Section 9, along with a comment saying there is no way to ask a timezone-aware value for its own offset. Once this PR lands, those two `query error` blocks become value queries (`-6` and `0` for every `day_denver` row) and that comment is no longer true. Whichever of the two merges second needs to update the other; nothing is broken by merging in either order. Noting it here so it is not a surprise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
