adriangb commented on PR #25165: URL: https://github.com/apache/datafusion/pull/25165#issuecomment-5624379895
Heads up on merge order: https://github.com/apache/datafusion/pull/25175 adds a timezone characterization suite (`test_files/datetime/timestamps_timezone.slt`) whose SECTION 5b pins the exact behaviour this PR changes — `AT TIME ZONE` on an already timezone-aware column, both the `arrow_typeof` and the value. Whichever of the two merges second will need to update the other, and CI on it will be red until that happens. Concretely, after this PR lands the two queries in SECTION 5b become: ``` SELECT arrow_typeof(column1 AT TIME ZONE 'Europe/Brussels'), column1 AT TIME ZONE 'Europe/Brussels' FROM c_utc Timestamp(ns, "Europe/Brussels") 2024-01-15T13:00:00+01:00 -> Timestamp(ns) 2024-01-15T13:00:00 Timestamp(ns, "Europe/Brussels") 2024-07-01T14:00:00+02:00 -> Timestamp(ns) 2024-07-01T14:00:00 SELECT arrow_typeof(column1 AT TIME ZONE 'America/Denver'), column1 AT TIME ZONE 'America/Denver' FROM c_denver Timestamp(ns, "America/Denver") 2024-01-15T12:00:00-07:00 -> Timestamp(ns) 2024-01-15T12:00:00 Timestamp(ns, "America/Denver") 2024-07-01T12:00:00-06:00 -> Timestamp(ns) 2024-07-01T12:00:00 ``` and the `DIVERGES FROM POSTGRESQL (type, not instant)` comment above them should be deleted, since this PR removes that divergence. Nothing else in that file conflicts — its other `AT TIME ZONE` cases all apply the operator to a timezone-naive input, which this PR leaves alone. The same note is in #25175's description. No action needed here; just so whoever merges either one knows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
