adriangb commented on PR #25139: URL: https://github.com/apache/datafusion/pull/25139#issuecomment-5623469247
Agreed. These checks are for error quality, not correctness. The physical planner already rejects a misplaced window/aggregate function in every position; it just can't point into the SQL text or suggest a fix, and its message was the Debug dump. Pushed two more commits: - 393b8912ec: readable backstop in create_physical_expr (and LIMIT/OFFSET), covers every position including the DataFrame API. - f829e8d3c8: precise checks for JOIN ON, GROUP BY and VALUES, same shape as WHERE/HAVING. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
