adriangb commented on PR #25162: URL: https://github.com/apache/datafusion/pull/25162#issuecomment-5623319042
Closing this for now. On reflection this page documents several things that are bugs or unresolved inconsistencies, and writing them down as reference material presents them as designed and intended. That is the wrong signal — a table showing that `date_bin` and `date_trunc` disagree, or explaining how `::timestamptz` erases a timezone, makes those behaviours look like semantics to learn rather than defects to fix. The findings that motivated those sections have been filed as issues instead, so nothing is lost: - https://github.com/apache/datafusion/issues/25166 — `TIMESTAMP WITH TIME ZONE` resolving to a naive type, and casting to `timestamptz` discarding an existing timezone (the root cause of #13962, includes the history of how the default changed in #18359) - https://github.com/apache/datafusion/issues/25167 — `date_bin` and `date_trunc` disagreeing on timezone-aware values - https://github.com/apache/datafusion/issues/25168 — `date_bin` with an explicit origin drifting across a DST transition - https://github.com/apache/datafusion/issues/25169 — `generate_series` accepting only nanosecond timestamps, with a misleading error - https://github.com/apache/datafusion/issues/25170 — `AT TIME ZONE '+05:30'` using the opposite sign convention from PostgreSQL #10344 stays open. Documenting timezone semantics is still worth doing — but it should describe behaviour we intend to keep, which means it wants writing after the issues above are resolved or explicitly accepted, not before. One piece of this is worth keeping regardless, and I will send it separately: `data_types.md` is currently missing the `TIMESTAMP WITH TIME ZONE` row altogether. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
