rtyler opened a new pull request, #25160:
URL: https://github.com/apache/datafusion/pull/25160
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #17689
## Rationale for this change
Our MSRV is well past the time when Rust supported async in traits and impls
without the async-trait proc macro (1.75 IIRC). I was purging unnecessary
dependencies in delta-io/delta-rs and async-trait kept popping back up in
analyses slowing build performance, so I figured I would come up to datafusion
to remove it and stumbled into @@abhiaagarwal's issue.
I kicked this off to the :parrot: and have reviewed the code, which required
touching a lot of callsites to get rid of async-trait.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
Please explain the problem you are trying to solve in terms of the
user-visible
behavior, rather than the implementation.
For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of the
implementation. "COUNT(DISTINCT) returns wrong results when the column
contains
nulls" is the user-visible problem.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here, but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## What is the testing strategy for this PR?
Build times are as follows
`cargo clean && cargo buiild`
#### this change
```
cargo build -q 266.10s user 28.41s system 343% cpu 1:25.66 total
cargo build -q 265.79s user 29.05s system 350% cpu 1:24.06 total
cargo build -q 268.33s user 28.77s system 358% cpu 1:22.90 total
cargo build -q 268.70s user 29.15s system 357% cpu 1:23.22 total
cargo build -q 268.15s user 29.37s system 350% cpu 1:24.92 total
```
#### main
```
cargo build -q 330.73s user 29.07s system 364% cpu 1:38.70 total
cargo build -q 333.32s user 28.76s system 366% cpu 1:38.85 total
cargo build -q 332.66s user 29.11s system 360% cpu 1:40.33 total
cargo build -q 332.29s user 28.71s system 360% cpu 1:40.18 total
cargo build -q 326.54s user 27.00s system 361% cpu 1:37.77 total
```
`cargo clean && cargo test --no-run`
#### this change
```
cargo test --no-run -q 853.07s user 68.46s system 702% cpu 2:11.21 total
cargo test --no-run -q 845.63s user 66.81s system 688% cpu 2:12.48 total
cargo test --no-run -q 855.27s user 68.27s system 698% cpu 2:12.17 total
cargo test --no-run -q 852.08s user 66.55s system 662% cpu 2:18.58 total
cargo test --no-run -q 858.76s user 65.37s system 673% cpu 2:17.28 total
```
### main
```
cargo test --no-run -q 1202.84s user 65.00s system 694% cpu 3:02.49 total
cargo test --no-run -q 1200.00s user 64.87s system 730% cpu 2:53.21 total
cargo test --no-run -q 1202.23s user 63.49s system 730% cpu 2:53.20 total
cargo test --no-run -q 1205.25s user 64.31s system 739% cpu 2:51.61 total
cargo test --no-run -q 1198.76s user 64.36s system 726% cpu 2:53.96 total
```
## Are there any user-facing changes?
negative ghost rider
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
