dwsmith1983 commented on PR #5466: URL: https://github.com/apache/datafusion-comet/pull/5466#issuecomment-5618346936
@peterxcli Andy asked on #5613 that we agree an order between #5466 and #5613, since both touch `try_grow` in `fair_pool.rs`. #5613 keeps the fair-limit check and the reservation as one step under the lock, then makes the JVM call with no lock held. #5466 changes what that check is measured against. The two compose: the per-reservation basis applies to the reserve-under-lock step rather than replacing it, and the two comments explaining the `state.used` basis get rewritten for the new basis rather than merged. Either order works. If #5466 lands first I rebase #5613 onto it and carry the per-reservation basis into the locked step. If #5613 goes first, your change lands on a `try_grow` whose JVM call is already outside the lock, so the rebase is the admission check and its comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
