alamb commented on code in PR #11711:
URL: https://github.com/apache/datafusion/pull/11711#discussion_r1723846223
##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -1034,29 +1033,61 @@ fn is_time_with_valid_unit(datatype: DataType) -> bool {
)
}
+/// Non-strict Timezone Coercion is useful in scenarios where we can guarantee
+/// a stable relationship between two timestamps of different timezones.
+///
+/// An example of this is binary comparisons (<, >, ==, etc). Arrow stores
timestamps
+/// as relative to UTC epoch, and then adds the timezone as an offset. As a
result, we can always
+/// do a binary comparison between the two times.
Review Comment:
> Or well, I'm pretty sure it's not guaranteed to be correct, but maybe it's
convenient enough to exist 🤷
I think it at least has guaranteed semantics 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
