2010YOUY01 commented on code in PR #25104:
URL: https://github.com/apache/datafusion/pull/25104#discussion_r3966644006
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -888,6 +888,10 @@ pub struct AggregateExec {
metrics: ExecutionPlanMetricsSet,
required_input_ordering: Option<OrderingRequirements>,
/// Describes how the input is ordered relative to the group by columns
+ ///
+ /// This field is also overloaded to mean "the output MUST preserve this
Review Comment:
This is an existing assumption, and I feel it's slightly confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
