kosiew commented on code in PR #25076:
URL: https://github.com/apache/datafusion/pull/25076#discussion_r3966257024
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -7360,6 +7407,153 @@ mod tests {
Ok(())
}
+ /// Builds a two-partition probe side for the cross-partition null-aware
+ /// tests: partition 0 holds the only NULL key, partition 1 holds none.
+ fn build_two_partition_probe_with_null_in_partition_0() -> Arc<dyn
ExecutionPlan> {
Review Comment:
Could we also add a two-partition `LeftAnti` case where the NULL-bearing
probe partition uses a dictionary key containing only a logical NULL? The
existing dictionary test is single-partition, while this new helper covers
physical `Int32` NULLs. I think that would be useful for exercising the
`logical_null_count()` path through the new cross-partition summary. This is
non-blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
