Ruchirtripathi commented on code in PR #24715: URL: https://github.com/apache/datafusion/pull/24715#discussion_r3964700464
########## datafusion/sql/src/statement.rs: ########## Review Comment: Thanks for catching this! @kosiew I've updated statement_to_plan to validate the constructed LogicalPlan at the boundary as suggested, ensuring that both COPY and EXPLAIN COPY paths are now properly checked. I also kept the existing validation in sql_statement_to_plan_with_context for public callers. Additionally, I've added the regression test for the COPY case, along with a boundary test to ensure that valid identifiers like user__common_expr_1 are still accepted. Let me know if this looks good to you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
