milenkovicm commented on PR #2431: URL: https://github.com/apache/datafusion-ballista/pull/2431#issuecomment-5591045191
thanks @andygrove will address your comments > Last one, the rationale sells the traits as a seam for object store and remote backends, but they are pub(crate) and there is no constructor taking them, so an embedder cannot plug one in yet. Worth either exposing them or trimming that from the description. I will need another pass to support object stores as PathBuf should be changed for object store equivalent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
