Copilot commented on code in PR #25050: URL: https://github.com/apache/datafusion/pull/25050#discussion_r3954822786
########## datafusion/sqllogictest/test_files/first_last_ordered.slt: ########## @@ -0,0 +1,97 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# End-to-end coverage for the grouped first_value/last_value pre-ordered fast +# path (issue #24771): when `OptimizeAggregateOrder` proves the input ordering +# satisfies the group-by prefix followed by the aggregate's ordering +# requirement, the grouped accumulator skips its per-row tournament. These +# queries exercise the whole chain — the requirement being proven through +# declared orderings, through projection-alias equivalences, and through +# filter-induced constants — and pin the results. + +statement ok +CREATE EXTERNAL TABLE multiple_ordered_table ( + a0 INTEGER, + a INTEGER, + b INTEGER, + c INTEGER, + d INTEGER +) +STORED AS CSV +WITH ORDER (a ASC, b ASC) +WITH ORDER (c ASC) +LOCATION '../../datafusion/core/tests/data/window_2.csv' Review Comment: The `LOCATION` path looks incorrect relative to `datafusion/sqllogictest/test_files`: other sqllogictest files reference `window_2.csv` via `../core/tests/data/window_2.csv`, but this file uses `../../datafusion/core/...`, which likely won’t resolve when the tests run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
