peterxcli commented on PR #25000: URL: https://github.com/apache/datafusion/pull/25000#issuecomment-5579942146
Thanks @jayzhan211. Addressed both suggestions in 223d0d6fd. The inverse loop now stops when its intersection is empty. Later row groups skip inverse evaluation once guaranteed rows cover the limit. The count includes fully matched row groups and intersects page selections with existing access selections, matching `limit_pruned_plan`. Added a regression test covering eight cases and checking predicate evaluation counts, including partial selections, insufficient matches, and absent/zero limits. Validation passed: - Page-filter unit tests. - `cargo clippy --all-targets --all-features -- -D warnings`. - `./dev/rust_lint.sh`. - The required extended workspace test command with `--profile ci` and `parquet_encryption`, including all 241 Parquet integration tests and 511 SQL logic test files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
