geographybuff opened a new pull request, #25048: URL: https://github.com/apache/datafusion/pull/25048
## Which issue does this PR close? No issue. This follows the precedent of prior comment-typo cleanups, which were merged without a linked issue: - #23662 `chore: Fix duplicated word typos in comments` (10 files, +14/-14) - #21495 ``chore: Fix `typo` problems`` (10 files, +14/-14) - #22625 `chore: Fix typos in comments` (2 files, +2/-2) - #22524 `chore: fix two comment typos` (2 files, +4/-4) - #20157 `chore: Fix typos in comments` (1 file, +2/-2) ## Rationale for this change Several comments and doc comments contain accidentally doubled words — `the sort sort options`, `can not not vary`, `types types from`. Four of them are rustdoc on public methods, so they render on docs.rs. These survive automated checking because the CI typo checker (`ci/scripts/typos_check.sh`, the `typos` crate) matches misspelled *words* and does not detect a correctly spelled word repeated twice in a row. Searching the tree for `\b(\w+)\s+\1\b` restricted to comment and prose lines finds the cases below; the remaining matches are ASCII-art plan diagrams and pasted `parquet-tools` output, which are left alone. ## What changes are included in this PR? Removes 7 doubled words across 6 Rust files and 1 documentation file (13 lines). Comment and prose text only — no code changes. | File | Fix | | --- | --- | | `datafusion/physical-expr-common/src/sort_expr.rs` (x4) | `Set the sort sort options` on the public `asc` / `desc` / `nulls_first` / `nulls_last` builders | | `datafusion/core/src/datasource/file_format/options.rs` (x4) | `can not not vary from statement to statement` on the CSV / Parquet / Arrow / Avro read options | | `datafusion/expr/src/window_frame.rs` | `equivalent values for all all terms` | | `datafusion/expr/src/logical_plan/plan.rs` | `properly infer types types from literal values` | | `datafusion/physical-plan/src/repartition/distributor_channels.rs` | `so we we can safely assume` | | `datafusion-examples/examples/query_planning/expr_api.rs` | `The same same expression` | | `docs/source/contributor-guide/testing.md` | `you can run them them locally` | ## What is the testing strategy for this PR? No new tests. The change is confined to comments and prose, so there is no behaviour to cover. Checks run locally on Linux x86_64 with the pinned 1.97.0 toolchain: - `cargo fmt --all --check` — pass - `cargo clippy --all-targets --all-features -- -D warnings` — pass, no warnings (full workspace, 22m) - `./ci/scripts/doc_prettier_check.sh` — pass - `cargo test --doc -p datafusion-physical-expr-common -p datafusion-expr -p datafusion` — pass, 254 tests (186 + 60 + 8), 0 failed I did not run the full extended test suite. No edited comment contains a doctest code fence, and the workspace compiles cleanly under `--all-features`, so the change cannot affect compiled or tested behaviour. Happy to run it if a reviewer would prefer. ## Are there any user-facing changes? No API or behaviour changes. The rendered rustdoc for four public `PhysicalSortExpr` builder methods and for the four `*ReadOptions` structs is corrected. --- ## AI disclosure This contribution was AI-assisted. Claude Code (Claude Opus 5) performed the tree-wide doubled-word search, made the 13 line edits, and ran every check listed above on Linux x86_64 with the pinned 1.97.0 toolchain. The contributor reviewed the diff and the check output before this PR was opened; the check commands themselves were executed by the AI and were not independently re-run by hand. The two `datafusion/core/src/lib.rs` doctests initially failed for a missing `parquet-testing` submodule (`PARQUET_TEST_DATA` undefined) rather than for any change in this PR; they pass once the submodule is initialised. That file is not touched by this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
