andygrove commented on code in PR #850:
URL: https://github.com/apache/datafusion-comet/pull/850#discussion_r1722496879
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -161,6 +161,45 @@ object CometConf extends ShimCometConf {
defaultValue = false,
notes = Some("stddev is slower than Spark's implementation"))
+ val COMET_EXEC_PROJECT_DISABLED: ConfigEntry[Boolean] =
+ createExecDisabledConfig(OPERATOR_PROJECT, defaultValue = false)
+ val COMET_EXEC_FILTER_DISABLED: ConfigEntry[Boolean] =
+ createExecDisabledConfig(OPERATOR_FILTER, defaultValue = false)
+ val COMET_EXEC_SORT_DISABLED: ConfigEntry[Boolean] =
+ createExecDisabledConfig(OPERATOR_SORT, defaultValue = false)
+ val COMET_EXEC_LOCAL_LIMIT_DISABLED: ConfigEntry[Boolean] =
+ createExecDisabledConfig(OPERATOR_LOCAL_LIMIT, defaultValue = false)
+ val COMET_EXEC_GLOBAL_LIMIT_DISABLED: ConfigEntry[Boolean] =
+ createExecDisabledConfig(OPERATOR_GLOBAL_LIMIT, defaultValue = false)
+ val COMET_EXEC_BROADCAST_HASH_JOIN_DISABLED: ConfigEntry[Boolean] =
+ createExecDisabledConfig(OPERATOR_BROADCAST_HASH_JOIN, defaultValue =
false)
+ val COMET_EXEC_BROADCAST_EXCHANGE_DISABLED: ConfigEntry[Boolean] =
+ createExecDisabledConfig(OPERATOR_BROADCAST_EXCHANGE, defaultValue = false)
+ val COMET_EXEC_HASH_JOIN_DISABLED: ConfigEntry[Boolean] =
+ createExecDisabledConfig(OPERATOR_HASH_JOIN, defaultValue = false)
+ val COMET_EXEC_SORT_MERGE_JOIN_DISABLED: ConfigEntry[Boolean] =
Review Comment:
It seems strange to have both an `enabled` and `disabled` for each operator.
What do we do if both are true or both are false?
In https://github.com/apache/datafusion-comet/pull/840 I had suggested
another approach, which I wasn't too happy with, and @parthchandra had added
another suggestion in there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
