goutamadwant commented on code in PR #24491:
URL: https://github.com/apache/datafusion/pull/24491#discussion_r3911545378
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -2304,13 +2319,20 @@ impl NestedLoopJoinStream {
}
// Poll the replay stream for the next right batch
- match self
+ let result = match self
.right_data
.as_mut()
.expect("right_data must be present")
.poll_next_unpin(cx)
{
- Poll::Ready(Some(Ok(right_batch))) => {
+ Poll::Ready(result) => result,
+ Poll::Pending => return ControlFlow::Break(Poll::Pending),
+ };
+
+ let join_metric = self.metrics.join_metrics.join_time.clone();
Review Comment:
thanks @kosiew addressed in latest commit changes. Let me know if this looks
good now.I added a memory-limited JoinType::Right regression that exercises the
final `EmitGlobalRightUnmatched` spill replay and verifies its polling delay is
excluded from join_time. The test also asserts that the right spill is replayed
exactly once; an ablation with the old timer scope fails as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
