bvolpato commented on code in PR #23468:
URL: https://github.com/apache/datafusion/pull/23468#discussion_r3904213603
##########
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -344,10 +344,39 @@ async fn aggregate_multiple_keys() -> Result<()> {
#[tokio::test]
async fn aggregate_grouping_sets() -> Result<()> {
- roundtrip(
- "SELECT a, c, d, avg(b) FROM data GROUP BY GROUPING SETS ((a, c), (a),
(d), ())",
+ let proto = roundtrip_with_ctx(
+ "SELECT a, c, d, avg(b), sum(e) FROM data GROUP BY GROUPING SETS ((a,
c), (a), (d), ())",
Review Comment:
good point. added execution-level result assertions for all grouping sets in
`a4c54d2a0`. this now verifies both `avg(b)` and `sum(e)` values after the
round trip, not only output mapping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
