jayzhan211 commented on code in PR #12002:
URL: https://github.com/apache/datafusion/pull/12002#discussion_r1720868582
##########
datafusion/functions-nested/src/range.rs:
##########
@@ -317,6 +315,14 @@ fn gen_range_date(args: &[ArrayRef], include_upper: bool)
-> Result<ArrayRef> {
let values_builder = Date32Builder::new();
let mut list_builder = ListBuilder::new(values_builder);
+ if start_array.unwrap().is_null(0)
Review Comment:
Actually this function's signature is quite complex, I think we should use
`UserDefined` signature to handle all possible types and **coerce** them to the
expected one with `coerce_types`. Then we don't need to handle null inside the
actual computation here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
