jayzhan211 commented on code in PR #11989:
URL: https://github.com/apache/datafusion/pull/11989#discussion_r1720495484
##########
datafusion/physical-expr/src/window/built_in.rs:
##########
@@ -97,6 +97,10 @@ impl BuiltInWindowExpr {
}
impl WindowExpr for BuiltInWindowExpr {
+ fn func_name(&self) -> Result<&str> {
+ not_impl_err!("function name not determined")
Review Comment:
The reason is because I don't need it -- for name checking in `nullable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
