comphead commented on code in PR #5423:
URL: https://github.com/apache/datafusion-comet/pull/5423#discussion_r3846119150
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometMetricNode.scala:
##########
@@ -61,6 +61,17 @@ case class CometMetricNode(metrics: Map[String, SQLMetric],
children: Seq[CometM
else children.flatMap(_.leafNodes)
}
+ private[comet] def withoutAggregateMetrics(plan: SparkPlan): CometMetricNode
=
Review Comment:
it would be useful to comment the reason aggregation metrics are excluded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
