advitrocks9 opened a new pull request, #24596:
URL: https://github.com/apache/datafusion/pull/24596
## Which issue does this PR close?
- Part of #24209.
## Rationale for this change
The scalar functions page still has tables whose rows don't line up with
their borders, including the `arrow_field` example the issue links:
```
+-------------------------------------------------------------+
| arrow_field(Int64(1)) |
+-------------------------------------------------------------+
| {name: lit, data_type: Int64, nullable: false, metadata: {}} |
+-------------------------------------------------------------+
```
The data row is 64 wide, the borders are 63. These tables are hand-written
inside `sql_example` literals and `print_functions_docs` copies them onto the
page verbatim.
## What changes are included in this PR?
Padding and border widths on 32 tables across 24 sources in `functions`,
`functions-nested` and `functions-aggregate`, plus the regenerated
`scalar_functions.md` and `aggregate_functions.md`. No cell content changed,
except `nvl`, which has a stray backslash welded to a border
(`+---------------------+\`) that reaches the page as-is. That's removed.
The aggregate page is in scope again after #24503 because that pass was
equalising widths, and `first_value`'s row was already the right width with an
unpadded cell, so it went through untouched.
I did these by hand rather than scripting them: `round`'s table had a
17-wide row against a 16-wide border where the correct width is 18, so neither
line could just be widened to match the other.
Boxes 2 to 4 of the issue are a separate change. The check box 1 asks for is
a follow-up to this.
## Are these changes tested?
No test. Nothing in the repo reads a `sql_example` body yet, which is what
box 1 is for. `./dev/update_function_docs.sh` reproduces all three generated
pages byte for byte, so `config-docs-check` is green, and fmt, prettier and
clippy are clean on the three crates.
## Are there any user-facing changes?
The rendered docs pages only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
