andygrove commented on code in PR #836: URL: https://github.com/apache/datafusion-comet/pull/836#discussion_r1720067221
########## docs/source/user-guide/tuning.md: ########## @@ -37,6 +37,15 @@ Comet will allocate at least `spark.comet.memory.overhead.min` memory. If both `spark.comet.memoryOverhead` and `spark.comet.memory.overhead.factor` are set, the former will be used. +## Memory Tuning in clusters +In clusters like Kubernetes or YARN to make the resource manager respect correctly Comet memory parameters `spark.comet.memory*` +it is needed to pass to the starting command line additional Spark configuration parameter `--conf spark.plugins=org.apache.spark.CometPlugin` Review Comment: I'm curious why we don't specify the plugin in all cases instead of `--conf spark.sql.extensions=org.apache.comet.CometSparkSessionExtensions` since the plugin does (or can) register the session extensions? Other Spark accelerators specify a plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
