alamb commented on code in PR #12037: URL: https://github.com/apache/datafusion/pull/12037#discussion_r1719946588
########## datafusion/expr-common/src/lib.rs: ########## @@ -17,9 +17,13 @@ //! Logical Expr types and traits for [DataFusion] //! -//! This crate contains types and traits that are used by both Logical and Physical expressions. -//! They are kept in their own crate to avoid physical expressions depending on logical expressions. -//! +//! This crate contains types and traits that are used by both Logical and +//! Physical expressions. They are kept in their own crate to avoid physical +//! expressions depending on logical expressions. +//! +//! Note this crate is not intended to have substantial logic itself, but rather Review Comment: I added some additional explanation about this crate (partly as a justification about why it was ok to depend on in the physical optimizer) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
