github-actions[bot] commented on PR #24517: URL: https://github.com/apache/datafusion/pull/24517#issuecomment-5355331643
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v55.0.0 (current) Built [ 59.144s] (current) Parsing datafusion v55.0.0 (current) Parsed [ 0.036s] (current) Building datafusion v55.0.0 (baseline) Built [ 56.844s] (baseline) Parsing datafusion v55.0.0 (baseline) Parsed [ 0.037s] (baseline) Checking datafusion v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.950s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 119.577s] datafusion Building datafusion-physical-plan v55.0.0 (current) Built [ 37.294s] (current) Parsing datafusion-physical-plan v55.0.0 (current) Parsed [ 0.157s] (current) Building datafusion-physical-plan v55.0.0 (baseline) Built [ 37.380s] (baseline) Parsing datafusion-physical-plan v55.0.0 (baseline) Parsed [ 0.158s] (baseline) Checking datafusion-physical-plan v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.961s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 77.567s] datafusion-physical-plan Building datafusion-proto v55.0.0 (current) error: running cargo-doc on crate 'datafusion-proto' failed with output: ----- Compiling proc-macro2 v1.0.107 Compiling unicode-ident v1.0.24 Compiling quote v1.0.47 Compiling libc v0.2.189 Checking cfg-if v1.0.4 Compiling libm v0.2.16 Checking memchr v2.8.3 Compiling autocfg v1.5.1 Compiling num-traits v0.2.19 Compiling syn v2.0.119 Compiling syn v3.0.3 Checking bytes v1.12.1 Compiling jobserver v0.1.35 Compiling shlex v2.0.1 Compiling find-msvc-tools v0.1.11 Compiling zerocopy v0.8.56 Compiling cc v1.4.3 Compiling serde_core v1.0.229 Compiling getrandom v0.3.4 Checking foldhash v0.2.0 Checking allocator-api2 v0.2.21 Checking once_cell v1.21.4 Checking equivalent v1.0.2 Checking itoa v1.0.18 Checking hashbrown v0.17.1 Compiling synstructure v0.13.2 Compiling zmij v1.0.23 Checking indexmap v2.14.0 Compiling serde_json v1.0.151 Checking num-integer v0.1.47 Compiling version_check v0.9.5 Checking siphasher v1.0.3 Checking iana-time-zone v0.1.65 Compiling zerocopy-derive v0.8.56 Compiling zerofrom-derive v0.1.7 Checking chrono v0.4.45 Compiling ahash v0.8.12 Checking phf_shared v0.12.1 Compiling yoke-derive v0.8.2 Checking zerofrom v0.1.8 Checking num-bigint v0.5.1 Checking stable_deref_trait v1.2.1 Compiling chrono-tz v0.10.4 Checking yoke v0.8.3 Checking arrow-schema v59.2.0 Checking phf v0.12.1 Compiling pkg-config v0.3.34 Compiling zerovec-derive v0.11.5 Checking num-complex v0.4.6 Compiling displaydoc v0.2.7 Checking pin-project-lite v0.2.17 Compiling zstd-sys v2.0.16+zstd.1.5.7 Checking zerovec v0.11.8 Checking futures-core v0.3.34 Checking smallvec v1.15.2 Checking litemap v0.8.3 Checking tinystr v0.8.4 Checking lexical-util v1.0.7 Checking futures-sink v0.3.34 Checking writeable v0.6.4 Checking icu_locale_core v2.3.0 Checking potential_utf v0.1.6 Checking zerotrie v0.2.5 Compiling icu_normalizer_data v2.3.0 Checking utf8_iter v1.0.4 Compiling icu_properties_data v2.3.0 Checking icu_collections v2.3.0 Checking half v2.7.1 Checking icu_provider v2.3.0 Checking arrow-buffer v59.2.0 Compiling semver v1.0.28 Compiling zstd-safe v7.2.4 Compiling rustc_version v0.4.1 Checking arrow-data v59.2.0 Checking lexical-parse-integer v1.0.6 Checking lexical-write-integer v1.0.6 Checking futures-channel v0.3.34 Compiling futures-macro v0.3.34 Compiling tokio-macros v2.7.2 Compiling parking_lot_core v0.9.12 Checking futures-io v0.3.34 Checking arrow-array v59.2.0 Checking slab v0.4.12 Checking bitflags v2.13.1 Checking futures-task v0.3.34 Checking tokio v1.53.1 Checking futures-util v0.3.34 Checking arrow-select v59.2.0 Checking lexical-write-float v1.0.6 Checking lexical-parse-float v1.0.6 Checking icu_properties v2.3.0 Checking icu_normalizer v2.3.0 Compiling flatbuffers v25.12.19 Checking aho-corasick v1.1.5 Checking unicode-segmentation v1.13.3 Checking ryu v1.0.23 Checking regex-syntax v0.8.11 Checking base64 v0.23.1 Compiling crc32fast v1.5.0 Checking scopeguard v1.2.0 Compiling getrandom v0.4.3 Checking unicode-width v0.2.2 Checking lock_api v0.4.14 Checking comfy-table v7.2.2 Checking idna_adapter v1.2.2 Checking lexical-core v1.0.6 Checking arrow-ord v59.2.0 Checking atoi v2.0.0 Checking either v1.17.0 Checking alloc-no-stdlib v2.0.4 Checking twox-hash v2.1.3 Checking adler2 v2.0.1 Compiling snap v1.1.2 Checking simd-adler32 v0.3.10 Compiling thiserror v2.0.20 Checking regex-automata v0.4.18 Checking percent-encoding v2.3.2 Checking form_urlencoded v1.2.2 Checking miniz_oxide v0.8.9 Checking lz4_flex v0.14.0 Checking arrow-cast v59.2.0 Checking alloc-stdlib v0.2.4 Checking idna v1.1.0 Checking futures-executor v0.3.34 Compiling tracing-attributes v0.1.31 Compiling thiserror-impl v2.0.20 Checking regex v1.13.1 Checking tracing-core v0.1.36 Checking csv-core v0.1.13 Checking same-file v1.0.6 Checking simdutf8 v0.1.5 Checking zlib-rs v0.6.7 Checking tracing v0.1.44 Checking walkdir v2.5.0 Checking csv v1.4.0 Checking futures v0.3.34 Checking url v2.5.8 Checking brotli-decompressor v5.0.3 Checking itertools v0.14.0 Checking parking_lot v0.12.5 Checking flate2 v1.1.9 Compiling async-trait v0.1.92 Checking http v1.5.0 Compiling anyhow v1.0.104 Compiling serde v1.0.229 Checking humantime v2.4.0 Checking object_store v0.13.2 Checking brotli v8.0.4 Checking arrow-csv v59.2.0 Checking arrow-json v59.2.0 Checking zstd v0.13.3 Checking arrow-ipc v59.2.0 Checking arrow-string v59.2.0 Checking uuid v1.24.1 Checking arrow-row v59.2.0 Checking arrow-arith v59.2.0 Compiling serde_derive v1.0.229 Compiling seq-macro v0.3.6 Checking log v0.4.33 Checking arrow v59.2.0 Checking itertools v0.15.0 Checking parquet v59.2.0 Compiling prost-derive v0.14.4 Checking base64 v0.22.1 Compiling pin-project-internal v1.1.13 Checking pin-project v1.1.13 Checking ppv-lite86 v0.2.21 Checking prost v0.14.4 Checking pbjson v0.9.0 Checking rand_core v0.9.5 Compiling crossbeam-utils v0.8.22 Compiling rustix v1.1.4 Checking rand_chacha v0.9.0 Checking linux-raw-sys v0.12.1 Checking datafusion-doc v55.0.0 (/home/runner/work/datafusion/datafusion/datafusion/doc) Checking rand v0.9.5 Checking tokio-util v0.7.19 Checking hashbrown v0.14.5 Checking foldhash v0.1.5 Checking fastrand v2.5.0 Checking hashbrown v0.15.5 Checking dashmap v6.2.1 Checking fixedbitset v0.5.7 Checking petgraph v0.8.3 Compiling datafusion-macros v55.0.0 (/home/runner/work/datafusion/datafusion/datafusion/macros) Checking tempfile v3.27.0 Checking hex v0.4.3 Checking datafusion-common-runtime v55.0.0 (/home/runner/work/datafusion/datafusion/datafusion/common-runtime) Checking glob v0.3.4 Checking datafusion-common v55.0.0 (/home/runner/work/datafusion/datafusion/datafusion/common) Compiling object v0.39.1 Compiling liblzma-sys v0.4.8 Compiling stacker v0.1.25 Checking libbz2-rs-sys v0.2.5 Checking crc-catalog v2.5.0 Compiling heck v0.5.0 Compiling strum_macros v0.28.0 Compiling ar_archive_writer v0.5.3 Checking crc v3.4.0 Checking datafusion-proto-common v55.0.0 (/home/runner/work/datafusion/datafusion/datafusion/proto-common) Checking datafusion-expr-common v55.0.0 (/home/runner/work/datafusion/datafusion/datafusion/expr-common) Compiling psm v0.1.32 Checking bzip2 v0.6.1 Checking tokio-stream v0.1.19 Compiling recursive-proc-macro-impl v0.1.1 Checking recursive v0.1.1 Checking datafusion-proto-models v55.0.0 (/home/runner/work/datafusion/datafusion/datafusion/proto-models) Checking liblzma v0.4.8 Checking arrow-avro v59.2.0 Checking datafusion-physical-expr-common v55.0.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr-common) Checking datafusion-functions-window-common v55.0.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-window-common) Checking datafusion-functions-aggregate-common v55.0.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-aggregate-common) Checking datafusion-expr v55.0.0 (/home/runner/work/datafusion/datafusion/datafusion/expr) Checking datafusion-execution v55.0.0 (/home/runner/work/datafusion/datafusion/datafusion/execution) Checking datafusion-physical-expr v55.0.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr) Checking datafusion-functions v55.0.0 (/home/runner/work/datafusion/datafusion/datafusion/functions) Checking datafusion-physical-plan v55.0.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-plan) Checking datafusion-physical-expr-adapter v55.0.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr-adapter) error[E0027]: pattern does not mention field `projection` --> /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/sort_merge_join/exec.rs:779:13 | 779 | let Self { | _____________^ 780 | | left, 781 | | right, 782 | | on, ... | 796 | | cache: _, 797 | | } = self; | |_________^ missing field `projection` | help: include the missing field in the pattern | 796 - cache: _, 797 - } = self; 796 + cache: _, projection } = self; | help: if you don't care about this missing field, you can explicitly ignore it | 796 - cache: _, 797 - } = self; 796 + cache: _, projection: _ } = self; | help: or always ignore missing fields here | 796 - cache: _, 797 - } = self; 796 + cache: _, .. } = self; | error[E0027]: pattern does not mention field `projection` --> /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/sort_merge_join/exec.rs:870:13 | 870 | let protobuf::SortMergeJoinExecNode { | _____________^ 871 | | left, 872 | | right, 873 | | on, ... | 877 | | null_equality, 878 | | } = &**sort_join; | |_________^ missing field `projection` | help: include the missing field in the pattern | 877 - null_equality, 878 - } = &**sort_join; 877 + null_equality, projection } = &**sort_join; | help: if you don't care about this missing field, you can explicitly ignore it | 877 - null_equality, 878 - } = &**sort_join; 877 + null_equality, projection: _ } = &**sort_join; | help: or always ignore missing fields here | 877 - null_equality, 878 - } = &**sort_join; 877 + null_equality, .. } = &**sort_join; | For more information about this error, try `rustc --explain E0027`. error: could not compile `datafusion-physical-plan` (lib) due to 2 previous errors ----- error: failed to build rustdoc for crate datafusion-proto v55.0.0 note: this is usually due to a compilation error in the crate, and is unlikely to be a bug in cargo-semver-checks note: the following command can be used to reproduce the error: cargo new --lib example && cd example && echo '[workspace]' >> Cargo.toml && cargo add --path /home/runner/work/datafusion/datafusion/datafusion/proto --features avro,datafusion-datasource-avro,datafusion-datasource-parquet,default,json,parquet,recursive_protection,serde_json && cargo check && cargo doc Building datafusion-proto-models v55.0.0 (current) Built [ 24.382s] (current) Parsing datafusion-proto-models v55.0.0 (current) Parsed [ 0.133s] (current) Building datafusion-proto-models v55.0.0 (baseline) Built [ 24.106s] (baseline) Parsing datafusion-proto-models v55.0.0 (baseline) Parsed [ 0.137s] (baseline) Checking datafusion-proto-models v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 2.608s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron Failed in: field SortMergeJoinExecNode.projection in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:2563 field SortMergeJoinExecNode.projection in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:2563 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 53.129s] datafusion-proto-models Building datafusion-sqllogictest v55.0.0 (current) Built [ 98.127s] (current) Parsing datafusion-sqllogictest v55.0.0 (current) Parsed [ 0.022s] (current) Building datafusion-sqllogictest v55.0.0 (baseline) Built [ 98.673s] (baseline) Parsing datafusion-sqllogictest v55.0.0 (baseline) Parsed [ 0.024s] (baseline) Checking datafusion-sqllogictest v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.109s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 200.063s] datafusion-sqllogictest error: aborting due to failure to build rustdoc for crate datafusion-proto v55.0.0 ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
