github-actions[bot] commented on PR #24400: URL: https://github.com/apache/datafusion/pull/24400#issuecomment-5341657943
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.1.0 (current) Built [ 57.610s] (current) Parsing datafusion v54.1.0 (current) Parsed [ 0.036s] (current) Building datafusion v54.1.0 (baseline) Built [ 58.242s] (baseline) Parsing datafusion v54.1.0 (baseline) Parsed [ 0.038s] (baseline) Checking datafusion v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.991s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 118.865s] datafusion Building datafusion-common v54.1.0 (current) Built [ 34.094s] (current) Parsing datafusion-common v54.1.0 (current) Parsed [ 0.067s] (current) Building datafusion-common v54.1.0 (baseline) Built [ 34.411s] (baseline) Parsing datafusion-common v54.1.0 (baseline) Parsed [ 0.066s] (baseline) Checking datafusion-common v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 1.025s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 70.776s] datafusion-common Building datafusion-sql v54.1.0 (current) Built [ 42.366s] (current) Parsing datafusion-sql v54.1.0 (current) Parsed [ 0.033s] (current) Building datafusion-sql v54.1.0 (baseline) Built [ 42.382s] (baseline) Parsing datafusion-sql v54.1.0 (baseline) Parsed [ 0.035s] (baseline) Checking datafusion-sql v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.335s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure enum_missing: pub enum removed or renamed --- Description: A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_missing.ron Failed in: enum datafusion_sql::planner::NullOrdering, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/6eb2dd7e4b70d2305875b6754fa28edc91ff189d/datafusion/sql/src/planner.rs:169 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 86.197s] datafusion-sql Building datafusion-sqllogictest v54.1.0 (current) Built [ 98.912s] (current) Parsing datafusion-sqllogictest v54.1.0 (current) Parsed [ 0.023s] (current) Building datafusion-sqllogictest v54.1.0 (baseline) Built [ 99.519s] (baseline) Parsing datafusion-sqllogictest v54.1.0 (baseline) Parsed [ 0.025s] (baseline) Checking datafusion-sqllogictest v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.112s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 201.586s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
