jcsherin commented on code in PR #12030:
URL: https://github.com/apache/datafusion/pull/12030#discussion_r1719702820
##########
datafusion/physical-plan/src/windows/mod.rs:
##########
@@ -356,8 +356,11 @@ impl BuiltInWindowFunctionExpr for WindowUDFExpr {
}
fn field(&self) -> Result<Field> {
- let nullable = true;
- Ok(Field::new(&self.name, self.data_type.clone(), nullable))
+ Ok(Field::new(
+ &self.name,
+ self.data_type.clone(),
+ self.fun.nullable(),
Review Comment:
This is why `nullable` method was added to `WindowUDFImpl` so that the
user-defined window function can customize nullability of column values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
