github-actions[bot] commented on PR #24442: URL: https://github.com/apache/datafusion/pull/24442#issuecomment-5324109775
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-common v54.1.0 (current) Built [ 24.730s] (current) Parsing datafusion-common v54.1.0 (current) Parsed [ 0.044s] (current) Building datafusion-common v54.1.0 (baseline) Built [ 24.824s] (baseline) Parsing datafusion-common v54.1.0 (baseline) Parsed [ 0.046s] (baseline) Checking datafusion-common v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.936s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron Failed in: field OptimizerOptions.adaptive_join_build_side in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:1464 field OptimizerOptions.adaptive_join_build_side_peek_rows in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:1464 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 52.003s] datafusion-common Building datafusion-physical-plan v54.1.0 (current) Built [ 28.386s] (current) Parsing datafusion-physical-plan v54.1.0 (current) Parsed [ 0.108s] (current) Building datafusion-physical-plan v54.1.0 (baseline) Built [ 27.883s] (baseline) Parsing datafusion-physical-plan v54.1.0 (baseline) Parsed [ 0.109s] (baseline) Checking datafusion-physical-plan v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.903s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 58.847s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
