github-actions[bot] commented on PR #24429: URL: https://github.com/apache/datafusion/pull/24429#issuecomment-5317532946
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.1.0 (current) Built [ 47.679s] (current) Parsing datafusion v54.1.0 (current) Parsed [ 0.029s] (current) Building datafusion v54.1.0 (baseline) Built [ 47.099s] (baseline) Parsing datafusion v54.1.0 (baseline) Parsed [ 0.029s] (baseline) Checking datafusion v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.819s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 97.639s] datafusion Building datafusion-expr v54.1.0 (current) Built [ 23.638s] (current) Parsing datafusion-expr v54.1.0 (current) Parsed [ 0.064s] (current) Building datafusion-expr v54.1.0 (baseline) Built [ 24.095s] (baseline) Parsing datafusion-expr v54.1.0 (baseline) Parsed [ 0.063s] (baseline) Checking datafusion-expr v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 1.605s] 223 checks: 221 pass, 1 fail, 1 warn, 31 skip --- failure struct_marked_non_exhaustive: struct marked #[non_exhaustive] --- Description: A public struct has been marked #[non_exhaustive], which will prevent it from being constructed using a struct literal outside of its crate. It previously had no private fields, so a struct literal could be used to construct it outside its crate. ref: https://doc.rust-lang.org/cargo/reference/semver.html#attr-adding-non-exhaustive impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_marked_non_exhaustive.ron Failed in: struct MergeIntoOp in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:320 struct MergeIntoOp in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:320 struct MergeIntoOp in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:320 struct MergeIntoOp in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:320 --- warning partial_ord_struct_fields_reordered: struct fields reordered in #[derive(PartialOrd)] struct --- Description: A public struct that derives PartialOrd had its fields reordered. #[derive(PartialOrd)] uses the field order to set the struct's ordering behavior, so this change may break downstream code that relies on the previous order. ref: https://doc.rust-lang.org/std/cmp/trait.PartialOrd.html#derivable impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/partial_ord_struct_fields_reordered.ron Failed in: MergeIntoOp.on moved from position 1 to 2, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:324 MergeIntoOp.clauses moved from position 2 to 3, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:326 MergeIntoOp.on moved from position 1 to 2, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:324 MergeIntoOp.clauses moved from position 2 to 3, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:326 MergeIntoOp.on moved from position 1 to 2, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:324 MergeIntoOp.clauses moved from position 2 to 3, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:326 MergeIntoOp.on moved from position 1 to 2, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:324 MergeIntoOp.clauses moved from position 2 to 3, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:326 Summary semver requires new major version: 1 major and 0 minor checks failed Warning produced 1 major and 0 minor level warnings Finished [ 50.785s] datafusion-expr Building datafusion-optimizer v54.1.0 (current) Built [ 23.425s] (current) Parsing datafusion-optimizer v54.1.0 (current) Parsed [ 0.026s] (current) Building datafusion-optimizer v54.1.0 (baseline) Built [ 22.887s] (baseline) Parsing datafusion-optimizer v54.1.0 (baseline) Parsed [ 0.025s] (baseline) Checking datafusion-optimizer v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.205s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 47.469s] datafusion-optimizer Building datafusion-proto v54.1.0 (current) Built [ 44.629s] (current) Parsing datafusion-proto v54.1.0 (current) Parsed [ 0.016s] (current) Building datafusion-proto v54.1.0 (baseline) Built [ 44.766s] (baseline) Parsing datafusion-proto v54.1.0 (baseline) Parsed [ 0.016s] (baseline) Checking datafusion-proto v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.138s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 90.818s] datafusion-proto Building datafusion-proto-models v54.1.0 (current) Built [ 20.918s] (current) Parsing datafusion-proto-models v54.1.0 (current) Parsed [ 0.110s] (current) Building datafusion-proto-models v54.1.0 (baseline) Built [ 20.552s] (baseline) Parsing datafusion-proto-models v54.1.0 (baseline) Parsed [ 0.113s] (baseline) Checking datafusion-proto-models v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 2.285s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron Failed in: field MergeIntoOpNode.target_qualifier in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:540 field MergeIntoOpNode.target_qualifier in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:540 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 45.770s] datafusion-proto-models Building datafusion-session v54.1.0 (current) Built [ 32.752s] (current) Parsing datafusion-session v54.1.0 (current) Parsed [ 0.011s] (current) Building datafusion-session v54.1.0 (baseline) Built [ 32.071s] (baseline) Parsing datafusion-session v54.1.0 (baseline) Parsed [ 0.010s] (baseline) Checking datafusion-session v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.217s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 66.209s] datafusion-session Building datafusion-sql v54.1.0 (current) Built [ 35.061s] (current) Parsing datafusion-sql v54.1.0 (current) Parsed [ 0.026s] (current) Building datafusion-sql v54.1.0 (baseline) Built [ 35.358s] (baseline) Parsing datafusion-sql v54.1.0 (baseline) Parsed [ 0.027s] (baseline) Checking datafusion-sql v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.312s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 71.947s] datafusion-sql Building datafusion-sqllogictest v54.1.0 (current) Built [ 83.713s] (current) Parsing datafusion-sqllogictest v54.1.0 (current) Parsed [ 0.055s] (current) Building datafusion-sqllogictest v54.1.0 (baseline) Built [ 82.434s] (baseline) Parsing datafusion-sqllogictest v54.1.0 (baseline) Parsed [ 0.019s] (baseline) Checking datafusion-sqllogictest v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.116s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 169.715s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
