dhruvxvaishnav commented on PR #24285: URL: https://github.com/apache/datafusion/pull/24285#issuecomment-5276202361
@alamb The benchmark failed before running because `multi_group_by` already declares `required-features = ["test_utils"]`, while the benchmark runner invokes Criterion targets with only `--features=parquet`. This affects both the merge base and this branch, so it is not caused by the PR. The working command is: `cargo bench -p datafusion-physical-plan --bench multi_group_by --features test_utils` No change to this PR seems appropriate. The general runner fix would be to include each target's `required-features` from `cargo metadata` when invoking it. Could we rerun after that is supported, or treat the local benchmark results as sufficient? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
