4ktLuffy commented on PR #24219: URL: https://github.com/apache/datafusion/pull/24219#issuecomment-5262956524
Thanks for the pointer — you're right, and I should have found this before opening the PR. string_query.slt.part covers everything I added: it's included by string.slt, large_string.slt, dictionary_utf8.slt, and string_view.slt, so each case already runs under all four string types — including Utf8View, which was the core of my rationale — and the unicode_1 fixture already mixes 2-, 3-, and 4-byte code points with negative-index cases (LEFT(unicode_1, -3), RIGHT(unicode_1, -3)). I also checked whether literal (scalar) invocation takes a distinct path that might warrant separate cases: it doesn't — both functions go through make_scalar_function, which converts scalar args to 1-row arrays before the shared implementation, so literal and column calls converge upstream of the byte/char handling. No residual gap I can find. Closing — thanks for the quick review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
