jayzhan211 commented on code in PR #11969:
URL: https://github.com/apache/datafusion/pull/11969#discussion_r1718065465
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -146,6 +146,8 @@ pub enum ArrayFunctionSignature {
/// Specialized Signature for MapArray
/// The function takes a single argument that must be a MapArray
MapArray,
+ /// Specialized Signature for MapExtract and similar functions
+ MapArrayAndKey,
Review Comment:
Only if there are more than 1 functions has the same signature, we could add
it
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -146,6 +146,8 @@ pub enum ArrayFunctionSignature {
/// Specialized Signature for MapArray
/// The function takes a single argument that must be a MapArray
MapArray,
+ /// Specialized Signature for MapExtract and similar functions
+ MapArrayAndKey,
Review Comment:
Only if there are more than 1 functions utilize the same signature, we could
add it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
