github-actions[bot] commented on PR #24276: URL: https://github.com/apache/datafusion/pull/24276#issuecomment-5257392934
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-expr-common v54.1.0 (current) Built [ 24.931s] (current) Parsing datafusion-expr-common v54.1.0 (current) Parsed [ 0.020s] (current) Building datafusion-expr-common v54.1.0 (baseline) Built [ 19.719s] (baseline) Parsing datafusion-expr-common v54.1.0 (baseline) Parsed [ 0.019s] (baseline) Checking datafusion-expr-common v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.306s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure type_method_marked_deprecated: type method #[deprecated] added --- Description: A type method is now #[deprecated]. Downstream crates will get a compiler warning when using this method. ref: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/type_method_marked_deprecated.ron Failed in: method datafusion_expr_common::sort_properties::SortProperties::and_or in /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/sort_properties.rs:116 Summary semver requires new minor version: 0 major and 1 minor checks failed Finished [ 46.343s] datafusion-expr-common Building datafusion-physical-expr v54.1.0 (current) Built [ 28.754s] (current) Parsing datafusion-physical-expr v54.1.0 (current) Parsed [ 0.052s] (current) Building datafusion-physical-expr v54.1.0 (baseline) Built [ 29.018s] (baseline) Parsing datafusion-physical-expr v54.1.0 (baseline) Parsed [ 0.054s] (baseline) Checking datafusion-physical-expr v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.475s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron Failed in: LambdaExpr::used_param_indices, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/6309cb6fc195ad2040ac8c5fb7851c81b02f3428/datafusion/physical-expr/src/expressions/lambda.rs:193 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 59.846s] datafusion-physical-expr Building datafusion-sqllogictest v54.1.0 (current) Built [ 187.688s] (current) Parsing datafusion-sqllogictest v54.1.0 (current) Parsed [ 0.022s] (current) Building datafusion-sqllogictest v54.1.0 (baseline) Built [ 186.879s] (baseline) Parsing datafusion-sqllogictest v54.1.0 (baseline) Parsed [ 0.023s] (baseline) Checking datafusion-sqllogictest v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.114s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 378.133s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
