jayzhan211 commented on code in PR #11989:
URL: https://github.com/apache/datafusion/pull/11989#discussion_r1717148941
##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -328,10 +328,45 @@ impl ExprSchemable for Expr {
Ok(true)
}
}
+ Expr::WindowFunction(WindowFunction { fun, .. }) => {
+ match fun {
+ WindowFunctionDefinition::BuiltInWindowFunction(func) => {
+ if func.name() == "ROW_NUMBER"
+ || func.name() == "RANK"
+ || func.name() == "NTILE"
+ || func.name() == "CUME_DIST"
+ {
+ Ok(false)
+ } else {
+ Ok(true)
+ }
+ }
+ WindowFunctionDefinition::AggregateUDF(func) => {
+ // TODO: UDF should be able to customize nullability
+ if func.name() == "count" {
+ // TODO: there is issue unsolved for count with
window, should return false
Review Comment:
Not so familiar with window function yet, leave it as TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
