Rachelint commented on code in PR #11943:
URL: https://github.com/apache/datafusion/pull/11943#discussion_r1716358223
##########
datafusion/functions-aggregate-common/src/aggregate/groups_accumulator/bool_op.rs:
##########
@@ -68,11 +70,21 @@ where
fn update_batch(
Review Comment:
Yes, I agree.
Maybe we can modify it when we start to support the blocked mode in the
specific `GroupAccumulator` or `GroupValues` impl. Seems it will be a too large
change, if we change all of them once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
