Punisheroot opened a new pull request, #24078:
URL: https://github.com/apache/datafusion/pull/24078
## Which issue does this PR close?
- Refs #13867.
## Rationale for this change
This adds a focused, reproducible microbenchmark for `ArrowBytesMap` so that
proposed implementation changes can be measured against `main` using the same
workloads. The benchmark is intentionally separated from the optimization, as
requested during review.
## What changes are included in this PR?
- Register a Criterion benchmark target for
`datafusion-physical-expr-common`.
- Add workloads covering:
- unique 4-byte values;
- unique 32-byte values;
- 32-byte values with low cardinality.
This PR changes measurement coverage only. It does not change the
`ArrowBytesMap` implementation or runtime behavior.
## Are these changes tested?
Yes. The benchmark was previously compiled and run on Ubuntu 24.04 under WSL2
as part of the measurements in the original combined PR. The following checks
were also previously run against these exact benchmark files:
- `cargo fmt --all --check`
- `cargo clippy --all-targets --all-features -- -D warnings`
- `cargo test -p datafusion-physical-expr-common --all-features`
- `cargo test -p datafusion-physical-plan group_values`
No commands were rerun for this history-only split.
## Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
