alamb commented on code in PR #11968:
URL: https://github.com/apache/datafusion/pull/11968#discussion_r1715810357
##########
datafusion/sqllogictest/test_files/string_view.slt:
##########
@@ -726,7 +726,7 @@ EXPLAIN SELECT
FROM test;
----
logical_plan
-01)Projection: overlay(CAST(test.column1_utf8view AS Utf8), Utf8("foo"),
Int64(2)) AS c1
+01)Projection: overlay(test.column1_utf8view, Utf8View("foo"), Int64(2)) AS c1
02)--TableScan: test projection=[column1_utf8view]
Review Comment:
Likewise, can we please also add actually running these queries to the tests
like
```sql
query
SELECT OVERLAY(column1_utf8view PLACING 'foo' FROM 2 ) as c1
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
