alamb commented on code in PR #11959:
URL: https://github.com/apache/datafusion/pull/11959#discussion_r1715808722
##########
datafusion/functions/src/core/mod.rs:
##########
@@ -94,6 +94,7 @@ pub fn functions() -> Vec<Arc<ScalarUDF>> {
nvl2(),
arrow_typeof(),
named_struct(),
+ get_field(),
Review Comment:
It might help to add the context of why this function is exported. Perhaps
something like
```suggestion
// Note most users invoke `get_field` indirectly via field access
syntax
// like `my_struct_col['field_name']` results in a call to
`get_field(my_struct_col, "field_name")`
// It is also exposed directly for use cases such as serializing /
deserializing plans with
// the field access desugared to calls to `get_field`
get_field(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
