berkaysynnada commented on PR #11966: URL: https://github.com/apache/datafusion/pull/11966#issuecomment-2286518231
> Great refactor! the code is super clear and understandable to me. > > One minor suggestion: a concrete example could make it even easier for someone reading the code for the first time. I drafted one (though not sure it's completely accurate) that you might consider using. Thanks for the suggestion. I'll use it with a little more elaboration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
