viirya commented on code in PR #821:
URL: https://github.com/apache/datafusion-comet/pull/821#discussion_r1714809977
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -3053,4 +3050,15 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
}
}
+
+ // TODO: Remove this constraint when we upgrade to new arrow-rs including
+ // https://github.com/apache/arrow-rs/pull/6225
+ def supportedSortType(op: SparkPlan, sortOrder: Seq[SortOrder]): Boolean = {
+ if (sortOrder.length == 1 &&
sortOrder.head.dataType.isInstanceOf[StructType]) {
+ withInfo(op, "Sort on single struct column is not supported")
Review Comment:
As @andygrove mentioned in #811, there are some more types that are not
supported. I will add them in other PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
