mbutrovich commented on PR #5032: URL: https://github.com/apache/datafusion-comet/pull/5032#issuecomment-5092714241
The description defers `make_interval` because "the dispatcher reports unsupported output type CalendarIntervalType and falls back". That is no longer true on main: commit 69df0f12b (#4898) added `CalendarIntervalType => true` to `CometBatchKernelCodegen.isSupportedDataType` (`spark/src/main/scala/org/apache/comet/codegen/CometBatchKernelCodegen.scala:92`), and `serializeDataType` already handles it (`spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:530` and `:571`). This PR is based on a pre-#4898 main, which is also why it conflicts. @peterxcli asked about exactly this. After the rebase, `object CometMakeInterval extends CometCodegenDispatch[MakeInterval]` plus a `classOf[MakeInterval]` entry should work with no further change. Either add it here or correct the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
