xudong963 commented on code in PR #23651:
URL: https://github.com/apache/datafusion/pull/23651#discussion_r3654085403
##########
datafusion/physical-plan/src/statistics.rs:
##########
@@ -182,35 +230,245 @@ impl StatisticsContext {
requests.len(),
children.len()
);
- let child_stats = children
+ let child_statistics: Vec<Arc<Statistics>> = children
Review Comment:
Thanks, this addresses my concern. Having
`StatisticsProvider::child_stats_requests` independent of
`ExecutionPlan::child_stats_requests` restores the original registry contract,
and reverting the CustomExec override is a good regression check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
