timsaucer commented on code in PR #22797:
URL: https://github.com/apache/datafusion/pull/22797#discussion_r3652710592
##########
datafusion/ffi/src/udf/mod.rs:
##########
@@ -100,6 +100,17 @@ pub struct FFI_ScalarUDF {
args: SVec<FFI_ExpressionPlacement>,
) -> FFI_ExpressionPlacement,
+ /// FFI equivalent to [`ScalarUDFImpl`]'s `with_updated_config`. Given the
Review Comment:
I see it matches the prior function, but these comments feel a bit pedantic
to me, because I'd think everyone reviewing this code would see these are the
1:1 mapping to the trait. Very much a nit-pick and doesn't require a change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
