andygrove commented on PR #4976: URL: https://github.com/apache/datafusion-comet/pull/4976#issuecomment-5070960331
The array-of-interval and top-level native-shuffle cases are nice coverage. Since `supportedSinkDataType` also allows intervals nested inside `StructType` and `MapType`, would it be worth adding a struct-with-interval-field and a map-with-interval-value case too? The nested struct field readers in `CometBatchKernelCodegenInput` do handle the interval cases, so the paths are probably already wired. A struct and a map test would confirm those permitted paths actually round-trip through the sink and shuffle, rather than just being allowed by the predicate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
