847850277 commented on code in PR #23784:
URL: https://github.com/apache/datafusion/pull/23784#discussion_r3642436538
##########
datafusion/physical-plan/src/empty.rs:
##########
@@ -185,6 +185,53 @@ impl ExecutionPlan for EmptyExec {
Ok(Arc::new(stats))
}
+
+ #[cfg(feature = "proto")]
+ fn try_to_proto(
+ &self,
+ _ctx: &crate::proto::ExecutionPlanEncodeCtx<'_>,
+ ) -> Result<Option<datafusion_proto_models::protobuf::PhysicalPlanNode>> {
+ use datafusion_proto_models::protobuf;
+ let schema = self.schema().as_ref().try_into()?;
+ Ok(Some(protobuf::PhysicalPlanNode {
+ physical_plan_type: Some(
+ protobuf::physical_plan_node::PhysicalPlanType::Empty(
+ protobuf::EmptyExecNode {
+ schema: Some(schema),
+ partitions: self
+ .properties()
+ .output_partitioning()
+ .partition_count() as u32,
+ },
+ ),
+ ),
+ }))
+ }
+}
+
+#[cfg(feature = "proto")]
+impl EmptyExec {
+ /// Reconstruct an [`EmptyExec`] from its protobuf representation.
+ pub fn try_from_proto(
+ node: &datafusion_proto_models::protobuf::PhysicalPlanNode,
+ _ctx: &crate::proto::ExecutionPlanDecodeCtx<'_>,
+ ) -> Result<Arc<dyn ExecutionPlan>> {
+ use datafusion_proto_models::protobuf;
+ let empty = crate::expect_plan_variant!(
+ node,
+ protobuf::physical_plan_node::PhysicalPlanType::Empty,
+ "EmptyExec",
+ );
+ let schema = empty.schema.as_ref().ok_or_else(|| {
+ datafusion_common::internal_datafusion_err!(
+ "EmptyExec is missing required field 'schema'"
+ )
+ })?;
+ let schema = Arc::new(arrow::datatypes::Schema::try_from(schema)?);
+ // Zero means the field was absent in the previous wire format.
Review Comment:
Fixed, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
