jayzhan211 commented on PR #11897: URL: https://github.com/apache/datafusion/pull/11897#issuecomment-2283302352
Ideally group by constant should be eliminated, but the result is different when there is no row and we can't differentiate it after `EliminateGroupByConstant`. I think this is why you bring the `is_global_group_by` information down to physical layer. I think another approach is we avoid `EliminateGroupByConstant` at all and we eliminate it when creating physical group by expression 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
