timsaucer commented on code in PR #23520:
URL: https://github.com/apache/datafusion/pull/23520#discussion_r3621860941
##########
datafusion/ffi/src/plan_properties.rs:
##########
@@ -282,6 +283,29 @@ mod tests {
))
}
+ fn create_range_test_props() -> Result<PlanProperties> {
+ use arrow::datatypes::{DataType, Field, Schema};
+ use datafusion_common::{ScalarValue, SplitPoint};
+ use datafusion_physical_expr::{LexOrdering, RangePartitioning};
+
Review Comment:
I don't have a strong opinion other than it should be consistent throughout
the file, so yes I'd recommend moving this up to the test module level. Then
let's merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
