stuhood commented on issue #21207: URL: https://github.com/apache/datafusion/issues/21207#issuecomment-5027168044
> The implementation in my PR happens to be > > * `InList`: `concat` the expressions > > * `Map`: `OR` the maps > > > Not sure if the `OR` is better or worse than `MultiMapLookupExpr`. So, FWIW: when we consume `InList` (e.g. "small") filters in our scans, we frequently tear them apart in order to evaluate them using an index, rather than using `Arrow`. If a dynamic filter has a lot of consumers then maybe it might make sense to execute these types of merges eagerly... but otherwise, letting the consumer decide whether it wants to further "optimize" it (concatenating, merging, etc) before applying it would be good for us. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
