peterxcli commented on PR #4715: URL: https://github.com/apache/datafusion-comet/pull/4715#issuecomment-5019741682
> One thing before this is good to go: the datatypes.md change flips DayTimeIntervalType to supported, but this PR is YearMonth-only and DayTime multiply/divide are still open The `DayTimeIntervalType` is supported along with https://github.com/apache/datafusion-comet/pull/4541, what hasn't really support is `*` or `/` expression for it(which is documented in the `expression.md`. > Could you flip only YearMonthIntervalType and leave DayTime at the pending marker, and adjust that intro line? I adjust the note to say: "Calendar interval fallback to spark now" in `datatypes.md` > Minor, non-blocking: a one-line comment in CometLiteral.getSupportLevel noting that YM interval is deliberately kept out of supportedDataType (so it does not get claimed as flowing through arbitrary native operators) would help the next reader. done. good catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
