alamb commented on code in PR #11845:
URL: https://github.com/apache/datafusion/pull/11845#discussion_r1709590649
##########
datafusion/functions-aggregate/Cargo.toml:
##########
@@ -44,6 +44,8 @@ arrow-schema = { workspace = true }
datafusion-common = { workspace = true }
datafusion-execution = { workspace = true }
datafusion-expr = { workspace = true }
+datafusion-functions-aggregate-common = { workspace = true }
+datafusion-physical-expr = { workspace = true }
Review Comment:
> We can see if `window` and/or `equivalence` staying here causes any
problems in practice. If so, I agree that they can be moved in the future.
However, it is also possible that they do not pose any challenges in practice
and can stay. We'll see soon enough 🚀
💯 agree
FWIW one project that would result in moving window functions would be
https://github.com/apache/datafusion/issues/8709
I suspect that is a relatively smaller project than moving scalar or
aggregates as there are so many fewer window functions
##########
datafusion/functions-aggregate/Cargo.toml:
##########
@@ -44,6 +44,8 @@ arrow-schema = { workspace = true }
datafusion-common = { workspace = true }
datafusion-execution = { workspace = true }
datafusion-expr = { workspace = true }
+datafusion-functions-aggregate-common = { workspace = true }
+datafusion-physical-expr = { workspace = true }
Review Comment:
> We can see if `window` and/or `equivalence` staying here causes any
problems in practice. If so, I agree that they can be moved in the future.
However, it is also possible that they do not pose any challenges in practice
and can stay. We'll see soon enough 🚀
💯 agree
FWIW one project that would likely result in moving window functions would
be https://github.com/apache/datafusion/issues/8709
I suspect that is a relatively smaller project than moving scalar or
aggregates as there are so many fewer window functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
