andygrove commented on PR #23458: URL: https://github.com/apache/datafusion/pull/23458#issuecomment-4939385574
> Also, a couple of smaller follow-ups: > > * the PR description says “raw f64 value slices”, but the implementation is now generic across `Float16/32/64` > * it would be useful to add benchmarks for partially-null inputs too, since the current numbers mostly validate the no-null fast path I addressed these points. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
